line-class.test.ts

packages/plinth-client/test/line-class.test.ts

1. /**
2. * Which order lines count as work this team owes.
3. *
4. * Every order-line count on the board (the queue, `ourMove`, `atVendor`,
5. * `waitingOnClient`, every person's workload) classifies each line with this
6. * rule. Classifying on the order status alone makes the queue show a handful of
7. * lines against a window holding hundreds.
8. *
9. * Neither field alone is right, because they go stale in opposite directions,
10. * and live Plinth data shows both:
11. *
12. * - order status stale behind: an order sitting "On Press" with a product
13. * line still in File Check is somebody's job today, and filtering on the
14. * order hides it.
15. * - product status stale ahead: the product row parks at its last value when
16. * an order ships. Most design-stage product lines in a typical fortnight sit
17. * on orders already shipped or delivered. Filtering on the product alone
18. * resurrects them as open artwork, which "makes the team look behind when it
19. * is not", the failure the board's own footer warns about.
20. *
21. * So the rule takes both: ours when the product says ours and the order has not
22. * moved past Part Dispatched.
23. */
25. import { describe, expect, it } from 'vitest'
26. import { classifyLine, isLineDesignQueue, isOrderPastFulfilment } from '../src/status-taxonomy.js'
28. const line = (productStatus: string, orderStatus: string) => ({
29. productStatus,
30. productStatusId: null,
31. orderStatus,
32. orderStatusId: null,
33. })
35. describe('the product row says what the work is', () => {
36. it('counts design work on an order that has already left for the vendor', () => {
37. // The line an order-only rule hides. "On Press" is at-vendor at the order
38. // level, so the whole line would vanish, including the artwork nobody had
39. // done.
40. expect(classifyLine(line('File Check', 'On Press'))).toBe('ours')
41. expect(classifyLine(line('File Check', 'Cleared For Print'))).toBe('ours')
42. })
44. it('keeps a line waiting on the client out of the team’s column', () => {
45. expect(classifyLine(line('Waiting On Files', 'On Press'))).toBe('client')
46. expect(classifyLine(line('Proof With Client', 'Proof Out'))).toBe('client')
47. })
49. it('keeps a line at the vendor out of it too', () => {
50. expect(classifyLine(line('Partner Dispatched', 'On Press'))).toBe('vendor')
51. })
52. })
54. describe('the order says whether the work is still here', () => {
55. it('drops a stale product row on an order that has shipped', () => {
56. // The phantom a product-only rule would create: several of these in a
57. // typical fortnight.
58. expect(classifyLine(line('File Check', 'Dispatched'))).toBe('terminal')
59. expect(classifyLine(line('File Check', 'Delivered'))).toBe('terminal')
60. expect(classifyLine(line('Waiting On Files', 'Awaiting Collection'))).toBe('terminal')
61. })
63. it('treats Part Dispatched as still here (Sam’s cutoff, 2026-09-17)', () => {
64. // The rule is "has not moved PAST Part Dispatched", so this one is in.
65. expect(isOrderPastFulfilment('Part Dispatched')).toBe(false)
66. expect(classifyLine(line('File Check', 'Part Dispatched'))).toBe('ours')
67. // And the next one along is out.
68. expect(isOrderPastFulfilment('Dispatched')).toBe(true)
69. })
71. it('drops cancelled and refunded orders, whatever the product row says', () => {
72. for (const s of ['Cancelled', 'Refunded', 'Claim Settled']) {
73. expect(classifyLine(line('File Check', s)), s).toBe('terminal')
74. }
75. })
77. it('keeps a cancellation REQUEST, because that is a decision somebody owes', () => {
78. // 'Cancel Requested' is classed 'ours' in the order catalog for
79. // exactly this reason, and it is not past fulfilment.
80. expect(isOrderPastFulfilment('Cancel Requested')).toBe(false)
81. })
82. })
84. describe('the unknown direction', () => {
85. it('lets a line through when the order status is one nobody has classified', () => {
86. // Same direction as classifyProduct's unknown default: a status nobody has
87. // seen yet should appear on the page and be noticed, not be filtered off it.
88. expect(isOrderPastFulfilment('Some New Status Ops Added')).toBe(false)
89. expect(classifyLine(line('File Check', 'Some New Status Ops Added'))).toBe('ours')
90. })
92. it('still counts an unknown PRODUCT status as ours, so it gets noticed', () => {
93. expect(classifyLine(line('Some New Product Status', 'On Press'))).toBe('ours')
94. })
95. })
97. describe('the design queue rides the same gate', () => {
98. it('counts artwork on a live order and not on a shipped one', () => {
99. expect(isLineDesignQueue(line('File Check', 'On Press'))).toBe(true)
100. expect(isLineDesignQueue(line('File Check', 'Dispatched'))).toBe(false)
101. })
103. it('does not count a line that is not design work', () => {
104. expect(isLineDesignQueue(line('Partner Dispatched', 'On Press'))).toBe(false)
105. })
106. })
108. describe('the two catalogs are not interchangeable', () => {
109. it('reads the product name against the PRODUCT catalog', () => {
110. // "Proof Out" exists only at order level. Putting it in the product field
111. // (which the dashboard fixture did until this change) hits the
112. // unknown-means-ours default and silently turns a client wait into team
113. // workload. That is how every fixture line read as work for one commit.
114. expect(classifyLine(line('Proof Out', 'Proof Out'))).toBe('ours')
115. // Whereas the product catalog's name for the same wait classifies right.
116. expect(classifyLine(line('Proof With Client', 'Proof Out'))).toBe('client')
117. })
118. })