mattrguerra.comHouston area
Matt Guerra
  1. 01AI & Automation
  2. 02Photography
  3. 03Design
  4. 04About
  5. 05Notes
  6. 06Contact
Back to the systems

mattrguerra/meridian-ops-boardmainPrivate on GitHub, published here in full

dates.test.ts

TypeScript8.5 KB223 lines

packages/ninety-client/test/dates.test.ts

  1. /**
  2. * Due dates must not shift by a day between the wire and the page.
  3. *
  4. * The expected values below are not invented. They are what the Ninety UI
  5. * showed in a screenshot, paired with the exact wire values the API returned for
  6. * the same to-dos. If these ever fail, the dashboard is lying about dates again.
  7. */
  9. import { describe, expect, it } from 'vitest'
  10. import {
  11. DEFAULT_REVIEW_DAYS,
  12. MERIDIAN_TZ,
  13. calendarDaysBetween,
  14. dueLabel,
  15. isActuallyLate,
  16. isOverdue,
  17. localDay,
  18. localDayBounds,
  19. reviewGatesMissed,
  20. shortDate,
  21. } from '../src/dates.js'
  22. import { RawTodoSchema, normalizeTodo, UNKNOWN_PERSON } from '../src/types.js'
  23. import fixture from './fixtures/todos.query.json' with { type: 'json' }
  25. /**
  26. * Ground truth. Left column is what came over the wire, right column is what the
  27. * Ninety UI displayed for that same to-do.
  28. */
  29. const GROUND_TRUTH = [
  30. { wire: '2026-08-08T04:59:59.999Z', ui: 'Aug 7', day: '2026-08-07' },
  31. { wire: '2026-08-15T04:59:59.999Z', ui: 'Aug 14', day: '2026-08-14' },
  32. { wire: '2026-07-25T04:59:59.999Z', ui: 'Jul 24', day: '2026-07-24' },
  33. { wire: '2026-09-01T04:59:59.999Z', ui: 'Aug 31', day: '2026-08-31' },
  34. ]
  36. describe('localDay: the bug', () => {
  37. it.each(GROUND_TRUTH)('$wire renders as $ui, not the UTC day', ({ wire, day }) => {
  38. expect(localDay(wire, MERIDIAN_TZ)).toBe(day)
  39. })
  41. it('proves slicing the ISO string is wrong', () => {
  42. // This is what the first version of the smoke test did.
  43. expect('2026-08-08T04:59:59.999Z'.slice(0, 10)).toBe('2026-08-08')
  44. expect(localDay('2026-08-08T04:59:59.999Z')).toBe('2026-08-07')
  45. })
  47. it('handles a winter date, where the UTC offset is -6 not -5', () => {
  48. // End of day Jan 15 CST is 06:00Z on Jan 16, not 05:00Z. A hardcoded
  49. // five-hour subtraction would get this wrong.
  50. expect(localDay('2026-01-16T05:59:59.999Z')).toBe('2026-01-15')
  51. })
  53. it('rejects garbage rather than silently returning a wrong day', () => {
  54. expect(() => localDay('not a date')).toThrow(RangeError)
  55. })
  56. })
  58. describe('shortDate matches how the Ninety UI writes dates', () => {
  59. it.each(GROUND_TRUTH)('$wire -> $ui', ({ wire, ui }) => {
  60. expect(shortDate(wire)).toBe(ui)
  61. })
  62. })
  64. describe('isOverdue uses instant comparison, which was never broken', () => {
  65. const now = new Date('2026-08-09T01:02:45.964Z') // a live smoke-test run
  67. it('a to-do due end of Aug 7 local is overdue on the evening of Aug 8', () => {
  68. expect(isOverdue('2026-08-08T04:59:59.999Z', now)).toBe(true)
  69. })
  71. it('a to-do due end of Aug 14 local is not yet overdue', () => {
  72. expect(isOverdue('2026-08-15T04:59:59.999Z', now)).toBe(false)
  73. })
  75. it('is not fooled by the last minute of the local day', () => {
  76. // 11:58 PM Central on Aug 7: the to-do is due at 11:59:59.999 and is not
  77. // overdue yet, even though the UTC date has already rolled over to Aug 8.
  78. const justBefore = new Date('2026-08-08T04:58:00.000Z')
  79. expect(isOverdue('2026-08-08T04:59:59.999Z', justBefore)).toBe(false)
  80. })
  82. it('treats a missing due date as not overdue', () => {
  83. expect(isOverdue(null, now)).toBe(false)
  84. })
  85. })
  87. describe('calendarDaysBetween counts whole days, ignoring time of day', () => {
  88. const now = new Date('2026-08-09T01:02:45.964Z') // evening of Aug 8 Central
  90. it('counts a to-do due end of Aug 7 as one day overdue', () => {
  91. expect(calendarDaysBetween(now, '2026-08-08T04:59:59.999Z')).toBe(-1)
  92. })
  94. it('counts the Jul 24 item as 15 days overdue, matching the smoke test', () => {
  95. expect(calendarDaysBetween(now, '2026-07-25T04:59:59.999Z')).toBe(-15)
  96. })
  98. it('counts forward correctly', () => {
  99. expect(calendarDaysBetween(now, '2026-08-15T04:59:59.999Z')).toBe(6)
  100. })
  102. it('does not round a late-evening due time into an extra day', () => {
  103. // 23:59 today is 0 days away, not 1.
  104. expect(calendarDaysBetween('2026-08-09T13:00:00Z', '2026-08-10T04:59:59.999Z')).toBe(0)
  105. })
  106. })
  108. describe('dueLabel', () => {
  109. const now = new Date('2026-08-09T01:02:45.964Z')
  111. it('reads the way the UI does, with a relative hint', () => {
  112. expect(dueLabel('2026-08-08T04:59:59.999Z', now)).toBe('Aug 7 (1 day overdue)')
  113. expect(dueLabel('2026-07-25T04:59:59.999Z', now)).toBe('Jul 24 (15 days overdue)')
  114. expect(dueLabel('2026-08-15T04:59:59.999Z', now)).toBe('Aug 14 (in 6 days)')
  115. })
  117. it('says today and tomorrow rather than "in 0 days"', () => {
  118. expect(dueLabel('2026-08-09T04:59:59.999Z', now)).toBe('Aug 8 (due today)')
  119. expect(dueLabel('2026-08-10T04:59:59.999Z', now)).toBe('Aug 9 (due tomorrow)')
  120. })
  122. it('handles no due date', () => {
  123. expect(dueLabel(null, now)).toBe('no due date')
  124. })
  125. })
  127. describe('localDayBounds, for "what changed since yesterday"', () => {
  128. it('spans a full local day during CDT', () => {
  129. const { startMs, endMs } = localDayBounds('2026-08-07')
  130. expect(new Date(startMs).toISOString()).toBe('2026-08-07T05:00:00.000Z')
  131. expect(endMs - startMs).toBe(86_400_000)
  132. })
  134. it('spans a full local day during CST', () => {
  135. const { startMs } = localDayBounds('2026-01-15')
  136. expect(new Date(startMs).toISOString()).toBe('2026-01-15T06:00:00.000Z')
  137. })
  139. it('contains a to-do due at end of that local day', () => {
  140. const { startMs, endMs } = localDayBounds('2026-08-07')
  141. const due = Date.parse('2026-08-08T04:59:59.999Z')
  142. expect(due).toBeGreaterThanOrEqual(startMs)
  143. expect(due).toBeLessThan(endMs)
  144. })
  145. })
  147. describe('reviewGatesMissed: Meridian closes to-dos only on Mondays', () => {
  148. // Saturday evening Aug 8, the moment the real smoke test ran.
  149. const now = new Date('2026-08-09T01:02:45.964Z')
  151. it('a to-do due Friday Aug 7 has missed zero gates on Saturday', () => {
  152. // Next review is Monday Aug 10. Overdue on paper, on time in practice.
  153. expect(reviewGatesMissed('2026-08-08T04:59:59.999Z', now)).toBe(0)
  154. expect(isOverdue('2026-08-08T04:59:59.999Z', now)).toBe(true)
  155. expect(isActuallyLate('2026-08-08T04:59:59.999Z', now)).toBe(false)
  156. })
  158. it('the Jul 24 item has missed two gates and is genuinely late', () => {
  159. // Mondays Jul 27 and Aug 3 both passed without it being closed.
  160. expect(reviewGatesMissed('2026-07-25T04:59:59.999Z', now)).toBe(2)
  161. expect(isActuallyLate('2026-07-25T04:59:59.999Z', now)).toBe(true)
  162. })
  164. it('turns "2 overdue" into "1 actually late" across the real open items', () => {
  165. const dues = ['2026-07-25T04:59:59.999Z', '2026-08-08T04:59:59.999Z', '2026-09-01T04:59:59.999Z']
  166. expect(dues.filter((d) => isOverdue(d, now))).toHaveLength(2)
  167. expect(dues.filter((d) => isActuallyLate(d, now))).toHaveLength(1)
  168. })
  170. it('does not count the review day an item is due on', () => {
  171. // Due Monday Aug 10, checked Tuesday Aug 11: the next chance is Aug 17.
  172. const tue = new Date('2026-08-12T01:00:00Z')
  173. expect(reviewGatesMissed('2026-08-11T04:59:59.999Z', tue)).toBe(0)
  174. })
  176. it('counts a Monday that has arrived', () => {
  177. // Due Friday Aug 7, checked Monday evening Aug 10.
  178. const mon = new Date('2026-08-11T01:00:00Z')
  179. expect(reviewGatesMissed('2026-08-08T04:59:59.999Z', mon)).toBe(1)
  180. })
  182. it('can include the occasional Wednesday review', () => {
  183. // Due Friday Jul 24, checked Sat Aug 8: Mondays 27, 3 plus Wednesdays 29, 5.
  184. expect(reviewGatesMissed('2026-07-25T04:59:59.999Z', now, { reviewDays: [1, 3] })).toBe(4)
  185. })
  187. it('defaults to Monday only, since assuming Wednesday would understate lateness', () => {
  188. expect(DEFAULT_REVIEW_DAYS).toEqual([1])
  189. })
  191. it('treats a to-do with no due date as not late', () => {
  192. expect(reviewGatesMissed(null, now)).toBe(0)
  193. expect(isActuallyLate(null, now)).toBe(false)
  194. })
  196. it('reports zero for a future due date', () => {
  197. expect(reviewGatesMissed('2026-09-01T04:59:59.999Z', now)).toBe(0)
  198. })
  199. })
  201. describe('normalizeTodo carries the corrected date through', () => {
  202. const now = new Date('2026-08-09T01:02:45.964Z')
  203. const todos = fixture.map((r) =>
  204. normalizeTodo(RawTodoSchema.parse(r), (id) => UNKNOWN_PERSON(id ?? ''), { now }),
  205. )
  207. it('exposes the local calendar day, not the UTC one', () => {
  208. expect(todos[0]!.dueDate).toBe('2026-08-08T04:59:59.999Z')
  209. expect(todos[0]!.dueDateLocal).toBe('2026-08-07')
  210. expect(todos[1]!.dueDateLocal).toBe('2026-08-14')
  211. })
  213. it('produces a label a person can check against the Ninety UI', () => {
  214. expect(todos[0]!.dueLabel).toBe('Aug 7 (1 day overdue)')
  215. expect(todos[1]!.dueLabel).toBe('Aug 14 (in 6 days)')
  216. })
  218. it('handles a to-do with no due date', () => {
  219. const t = normalizeTodo(RawTodoSchema.parse({ ...fixture[0], dueDate: null }), () => UNKNOWN_PERSON(''), { now })
  220. expect(t.dueDateLocal).toBeNull()
  221. expect(t.dueLabel).toBe('no due date')
  222. })
  223. })