leads.test.ts

packages/bitrix-client/test/leads.test.ts

1. import { describe, expect, it } from 'vitest'
2. import { isLikelyNoise, normalizeLead, type RawLead } from '../src/leads.js'
3. import { BitrixClient, BitrixOperationTimeError, BitrixRateLimitError } from '../src/http.js'
5. describe('lead noise detection', () => {
6. // Every one of these has the shape of a row in the live open-lead list.
7. it.each([
8. ['Security alert: new sign-in to your account', 'automated security notification'],
9. ['15550100123 - Incoming call (unknown)', 'call log entry'],
10. ['Complete CRM form "Website Chat"', 'unattended form submission'],
11. ['Blue guest #19 - Meridian Display Support', 'support chat guest record'],
12. ])('flags %s', (title, reason) => {
13. const r = isLikelyNoise(title)
14. expect(r.noise).toBe(true)
15. expect(r.reason).toBe(reason)
16. })
18. it.each([
19. 'Re: Event kit order for Lakeside Robotics Club',
20. 'Re: Custom flag order for Pinecrest Community Center',
21. 'RE: [EXTERNAL]Meridian Display | Setup instructions',
22. 'MD2641873',
23. ])('does not flag the real lead %s', (title) => {
24. expect(isLikelyNoise(title).noise).toBe(false)
25. })
27. it('flags rather than drops, so the count stays honest', () => {
28. const l = normalizeLead({ ID: '1', TITLE: 'Security alert: something' } as RawLead)
29. expect(l.noise).toBe(true)
30. expect(l.title).toBe('Security alert: something') // still present
31. })
32. })
34. describe('lead normalization', () => {
35. it('falls back to name fields when TITLE is absent', () => {
36. expect(normalizeLead({ ID: '1', NAME: 'Casey', LAST_NAME: 'Morgan' } as RawLead).title).toBe('Casey Morgan')
37. })
39. it('coerces OPPORTUNITY, which arrives as a string', () => {
40. expect(normalizeLead({ ID: '1', TITLE: 'x', OPPORTUNITY: '1250.00' } as RawLead).amount).toBe(1250)
41. expect(normalizeLead({ ID: '1', TITLE: 'x' } as RawLead).amount).toBe(0)
42. })
43. })
45. describe('the two Bitrix limits are handled differently', () => {
46. const client = (status: number, body: unknown) =>
47. new BitrixClient({
48. webhookUrl: 'https://x.bitrix24.com/rest/1/k/',
49. maxRetries: 1,
50. sleep: async () => {},
51. rps: 1000,
52. fetchImpl: (async () =>
53. new Response(JSON.stringify(body), {
54. status,
55. headers: { 'Content-Type': 'application/json' },
56. })) as unknown as typeof fetch,
57. })
59. it('treats 503 QUERY_LIMIT_EXCEEDED as the rate limit', async () => {
60. await expect(client(503, { error: 'QUERY_LIMIT_EXCEEDED' }).call('crm.lead.list')).rejects.toBeInstanceOf(
61. BitrixRateLimitError,
62. )
63. })
65. it('treats 429 as the per-method execution-time limit, NOT the rate limit', async () => {
66. // Inverted from most APIs, and from @meridian/ninety-client. Retrying now cannot help.
67. const c = client(429, { error: 'OPERATION_TIME_LIMIT', time: { operating_reset_at: 1786240000 } })
68. await expect(c.call('crm.lead.list')).rejects.toBeInstanceOf(BitrixOperationTimeError)
69. })
71. it('suspends only the offending method', async () => {
72. const c = client(429, { error: 'OPERATION_TIME_LIMIT', time: { operating_reset_at: 9999999999 } })
73. await expect(c.call('crm.lead.list')).rejects.toThrow(/suspended/)
74. // A second call to the same method fails fast without hitting the network.
75. await expect(c.call('crm.lead.list')).rejects.toBeInstanceOf(BitrixOperationTimeError)
76. })
78. it('refuses to construct without a webhook URL', () => {
79. expect(() => new BitrixClient({ webhookUrl: '' })).toThrow(/BITRIX_WEBHOOK_URL/)
80. })
81. })