fathom-topics.test.ts

apps/dashboard/test/fathom-topics.test.ts

1. /**
2. * Meeting action items, bucketed by topic.
3. *
4. * They render in a pop-out box, organised into buckets by topic, with one button
5. * per topic, rather than as one long list at the bottom of the page.
6. *
7. * Two things are worth holding here. The first is that the classifier is
8. * conservative: Fathom has no topic field, so these buckets are keyword rules a
9. * person wrote, and a rule that catches the wrong thing is worse than one that
10. * catches nothing. Uncategorized is honest, a wrong bucket is not. The second
11. * is the gate: buttons are derived from the viewer's own items, so they cannot
12. * advertise a meeting they were not in.
13. */
15. import { describe, expect, it } from 'vitest'
16. import {
17. FATHOM_TOPICS,
18. UNCATEGORIZED,
19. bucketByTopic,
20. topicFor,
21. topicSlug,
22. } from '../../../config/fathom-topics.js'
24. const item = (text: string, meeting = 'Impromptu Zoom Meeting') => ({ text, meeting })
26. describe('topicFor', () => {
27. it('reads the item text', () => {
28. expect(topicFor('upload the logo refs to Drive', '')).toBe('Creative & design')
29. expect(topicFor('pull the winback numbers', '')).toBe('Outreach & winback')
30. })
32. it('falls back to the meeting title when the item says nothing categorical', () => {
33. // "send it over" in a Design Review is a creative item even though its
34. // own words carry no signal. This is most of why the title is matched too.
35. expect(topicFor('send it over', 'Design Review w/ Nora')).toBe('Creative & design')
36. })
38. it('MATCHES WHOLE WORDS ONLY', () => {
39. // The trap this avoids, and the reason matchesFilter refuses substrings
40. // too: "ai" lives inside email, detail, again, chair; "comp" inside
41. // complete, company, compare. Substring matching would put half the board
42. // in the wrong bucket and look like it was working.
43. expect(topicFor('reply to the email', '')).not.toBe('AI & automation')
44. expect(topicFor('detail the plan', '')).not.toBe('AI & automation')
45. expect(topicFor('complete the writeup', '')).not.toBe('People & leadership')
46. // And still matches when it really is the word.
47. expect(topicFor('have AI draft it', '')).toBe('AI & automation')
48. expect(topicFor('ai-generated copy', '')).toBe('AI & automation')
49. })
51. it('is case-insensitive', () => {
52. expect(topicFor('Upload The LOGO', '')).toBe('Creative & design')
53. })
55. it('sends anything unmatched to Uncategorized rather than guessing', () => {
56. // A default that stands in for knowledge has to be visible. This
57. // bucket IS the report on the keyword map's coverage.
58. expect(topicFor('circle back with Jordan', 'Impromptu Zoom Meeting')).toBe(UNCATEGORIZED)
59. })
61. it('resolves a tie by list order, which is the human decision', () => {
62. // "logo" (Creative) and "campaign" (Outreach) both match; Creative is
63. // listed first, so it wins. Moving a topic up changes what its neighbours
64. // catch: that is why the config is a list and not a map.
65. const creativeFirst = FATHOM_TOPICS.findIndex((t) => t.label === 'Creative & design')
66. const outreachSecond = FATHOM_TOPICS.findIndex((t) => t.label === 'Outreach & winback')
67. expect(creativeFirst).toBeLessThan(outreachSecond)
68. expect(topicFor('logo for the campaign', '')).toBe('Creative & design')
69. })
70. })
72. describe('bucketByTopic', () => {
73. const items = [
74. item('upload the logo'),
75. item('resize the banner images'),
76. item('pull the winback numbers'),
77. item('circle back with Jordan'),
78. item('ask Claude to draft it'),
79. ]
81. it('puts every item in exactly one bucket, so the counts add up', () => {
82. // A number and the list under it must be able to account for each
83. // other. The page prints this sum, so it has to be true.
84. const buckets = bucketByTopic(items)
85. expect(buckets.reduce((n, b) => n + b.items.length, 0)).toBe(items.length)
86. const seen = buckets.flatMap((b) => b.items.map((i) => i.text))
87. expect(new Set(seen).size).toBe(items.length)
88. })
90. it('omits topics with nothing in them', () => {
91. // A button for an empty bucket is a control that does nothing, and on a
92. // per-person surface it would also advertise topics from meetings this
93. // viewer was not in.
94. const buckets = bucketByTopic([item('upload the logo')])
95. expect(buckets).toHaveLength(1)
96. expect(buckets[0]!.label).toBe('Creative & design')
97. })
99. it('orders buckets as the config does, with Uncategorized last', () => {
100. const labels = bucketByTopic(items).map((b) => b.label)
101. expect(labels[labels.length - 1]).toBe(UNCATEGORIZED)
102. const configOrder = FATHOM_TOPICS.map((t) => t.label)
103. const positions = labels.slice(0, -1).map((l) => configOrder.indexOf(l))
104. expect(positions).toEqual([...positions].sort((a, b) => a - b))
105. })
107. it('returns nothing for nothing, never an empty Uncategorized bucket', () => {
108. expect(bucketByTopic([])).toEqual([])
109. })
111. it('gives every bucket an attribute-safe slug', () => {
112. // The slug becomes a data-topic value and an element id. An ampersand or a
113. // space in either would break the pairing between button and panel.
114. for (const b of bucketByTopic(items)) {
115. expect(b.slug).toMatch(/^[a-z0-9-]+$/)
116. }
117. expect(topicSlug('Partner: Northgate')).toBe('partner-northgate')
118. expect(topicSlug('!!!')).toBe('topic')
119. })
121. it('keeps distinct labels on distinct slugs', () => {
122. const slugs = FATHOM_TOPICS.map((t) => topicSlug(t.label))
123. expect(new Set(slugs).size).toBe(slugs.length)
124. })
125. })
127. describe('the keyword map stays conservative', () => {
128. it('has no keyword short enough to catch words at random', () => {
129. // Two-letter keywords are the ones that go wrong even with whole-word
130. // matching, because they are also initials and abbreviations. "ai" is the
131. // deliberate exception and is why whole-word matching exists at all.
132. for (const t of FATHOM_TOPICS) {
133. for (const k of t.keywords) {
134. expect(k.length, `${t.label}: "${k}" is too short to be safe`).toBeGreaterThanOrEqual(
135. k === 'ai' ? 2 : 3,
136. )
137. }
138. }
139. })
141. it('lists no keyword twice across topics, which would make order silently matter more', () => {
142. const seen = new Map<string, string>()
143. for (const t of FATHOM_TOPICS) {
144. for (const k of t.keywords) {
145. expect(seen.has(k), `"${k}" is in both ${seen.get(k)} and ${t.label}`).toBe(false)
146. seen.set(k, t.label)
147. }
148. }
149. })
150. })